[feat] Implement state filter and multi select filters #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylezryr
force-pushed
the
19-implement-state-filter-and-multi-select-filters
branch
from
fcc6aef
to
7be66e3
Compare
| @@ -0,0 +1,14 @@ | |||
| import styled from 'styled-components'; | |||
There was a problem hiding this comment.
Can we make it so that the outline appears around the grey area, rather than in the middle of the bar?
app/seasonal-planting-guide/page.tsx
Outdated
| HeaderContainer, | ||
| PageContainer, | ||
| StateOptionsContainer, | ||
| } from './styles'; | ||
|
|
||
| const SeasonalPlantingGuide = () => { |
There was a problem hiding this comment.
to be consistent with the rest of the codebase, this should be
export default const SeasonalPlantingGuide
| }: FilterDropdownProps) { | ||
| return ( | ||
| <MultiSelect | ||
| options={options.map(option => ({ label: option, value: option }))} |
There was a problem hiding this comment.
let's actually map labels to the corresponding SeasonEnum values
components/SearchBar/SearchBar.tsx
Outdated
| @@ -0,0 +1,23 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
this file should be renamed to index.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR 🧑🌾
Description
Screenshots
How to review
Next steps
Relevant links
Online sources
https://linear.app/trap-garden/issue/TG-26/implement-state-filter-and-multi-select-filters
Related PRs
CC: @ccatherinetan